resolve conflicts

open-telemetry · Oct 8, 2021 · dc84c7d · dc84c7d
1 parent cc568e1
commit dc84c7d
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/src/OpenTelemetry/Metrics/MeterProviderSdk.cs b/src/OpenTelemetry/Metrics/MeterProviderSdk.cs
@@ -216,6 +216,7 @@ internal MeterProviderSdk(
                         OpenTelemetrySdkEventSource.Log.MetricInstrumentIgnored(instrument.Name, instrument.Meter.Name, "Instrument belongs to a Meter not subscribed by the provider.", "Use AddMeter to add the Meter to the provider.");
                         return;
                     }
+
                     try
                     {
                         var metricName = instrument.Name;
@@ -224,9 +225,7 @@ internal MeterProviderSdk(
                         {
                             if (this.metricStreamNames.ContainsKey(metricName))
                             {
-                                // TODO: Log that instrument is ignored
-                                // as the resulting Metric name is conflicting
-                                // with existing name.
+                                OpenTelemetrySdkEventSource.Log.MetricInstrumentIgnored(metricName, instrument.Meter.Name, "Metric name conflicting with existing name.", "Either change the name of the instrument or change name using View.");
                                 return;
                             }