Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept X-B3-Sampled header to equal true #1299

Closed
christopher-taormina-zocdoc opened this issue Sep 23, 2020 · 2 comments · Fixed by #1413
Closed

Accept X-B3-Sampled header to equal true #1299

christopher-taormina-zocdoc opened this issue Sep 23, 2020 · 2 comments · Fixed by #1413
Assignees
Labels
bug Something isn't working good first issue Good for newcomers help wanted Good for taking. Extra help will be provided by maintainers pkg:OpenTelemetry.Api Issues related to OpenTelemetry.Api NuGet package

Comments

@christopher-taormina-zocdoc
Copy link
Contributor

Feature Request

Right now when you use the B3Propagator for the AspNet/AspNetCore instrumentations, the incoming request needs to set the X-B3-Sampled header to 1 for the request to be sampled. As mentioned in the open zipkin repo some tracer implementations may have set this header to the value true instead of 1.

Can the B3Propagator be made to be lenient and accept this value as well? This would put much less burden on anyone moving to the open-telemetry instrumentation when services may have this older implementation.

@christopher-taormina-zocdoc christopher-taormina-zocdoc added the enhancement New feature or request label Sep 23, 2020
@reyang reyang added pkg:OpenTelemetry.Api Issues related to OpenTelemetry.Api NuGet package bug Something isn't working good first issue Good for newcomers help wanted Good for taking. Extra help will be provided by maintainers and removed enhancement New feature or request labels Oct 10, 2020
@reyang
Copy link
Member

reyang commented Oct 12, 2020

@vishweshbankwar this looks like a good first issue for you.

@christopher-taormina-zocdoc
Copy link
Contributor Author

@reyang just opened a PR for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Good for taking. Extra help will be provided by maintainers pkg:OpenTelemetry.Api Issues related to OpenTelemetry.Api NuGet package
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants