add support for true in x-b3-sampled #1413
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1413 +/- ##
==========================================
- Coverage 81.28% 81.23% -0.05%
==========================================
Files 227 227
Lines 6112 6113 +1
==========================================
- Hits 4968 4966 -2
- Misses 1144 1147 +3
|
|
@chris-smith-zocdoc Can you add a line to the changelog as well? Thank you! |
src/OpenTelemetry.Api/CHANGELOG.md
Outdated
| Released 2020-07-23 | ||
|
|
||
| * Initial release | ||
| # Changelog |
There was a problem hiding this comment.
some encoding got accidentaly changed to this file? there must have been some CI which detects this.
There was a problem hiding this comment.
didn't see that coming, let me take a look
There was a problem hiding this comment.
check if u are using utf8. I saw that sometimes it changed from utf8 to utf8-BOM.
There was a problem hiding this comment.
I edited it in vs code and it claimed it saved as utf-8
There was a problem hiding this comment.
you solved :) what was the issue in the end?
There was a problem hiding this comment.
definitely line endings lol
|
@christopher-taormina-zocdoc can you merge from the latest master? Usually maintainers/approvers have permission to do this in PR, but this one doesn't seem to have it, so you have to do it. |
|
@cijothomas just merged in master. The commit says |
|
Thanks @christopher-taormina-zocdoc |
Fixes #1299
Changes
Adds a string for the possible
X-B3-Sampledvalue oftrueand checks the received header against both values. Setting the header for outgoing requests remains unchanged.For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes