Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OTLP exporter improvements #1651

Closed
alanwest opened this issue Dec 10, 2020 · 0 comments · Fixed by #1662
Closed

OTLP exporter improvements #1651

alanwest opened this issue Dec 10, 2020 · 0 comments · Fixed by #1662
Assignees
Labels
bug Something isn't working

Comments

@alanwest
Copy link
Member

alanwest commented Dec 10, 2020

Currently the constructor for the OtlpExporter instantiates a gRPC channel here:

this.channel = new Channel(options.Endpoint, options.Credentials, options.ChannelOptions);

The channel constructor can throw an exception. I've encountered this when using a single file publish:

dotnet publish -r linux-x64 -p:PublishSingleFile=true

Using the single file publish causes this issue in the gRPC library grpc/grpc#24266.

#1616 also suggests that the OtlpExporter constructor is throwing an excption. I'm uncertain if it is the same one, but it is most likely the instantiation of the channel that is throwing here too.

Few things I'd like to suggest:

  1. Delay the instantiation of the channel to the first call to export data. This would allow us to catch the exception on export and not crash the application.
  2. Make a netstandard2.1 build of the OTLP exporter. This would enable us to use the grpc-dotnet library for .NET 3.1 and above instead of the native grpc library. This would:
@alanwest alanwest added the bug Something isn't working label Dec 10, 2020
@alanwest alanwest self-assigned this Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant