Catch general exception in OltpExporter (#1634)

* Catch general exception in OltpExporter * Corrected typo
open-telemetry · Nov 30, 2020 · 1630fb3 · 1630fb3
1 parent fcc0b56
commit 1630fb3
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 0 deletions.
diff --git a/...Exporter.OpenTelemetryProtocol/Implementation/OpenTelemetryProtocolExporterEventSource.cs b/...Exporter.OpenTelemetryProtocol/Implementation/OpenTelemetryProtocolExporterEventSource.cs
@@ -43,6 +43,15 @@ public void FailedToReachCollector(Exception ex)
             }
         }
 
+        [NonEvent]
+        public void ExportMethodException(Exception ex)
+        {
+            if (Log.IsEnabled(EventLevel.Error, (EventKeywords)(-1)))
+            {
+                this.ExportMethodException(ex.ToInvariantString());
+            }
+        }
+
         [Event(1, Message = "Exporter failed to convert SpanData content into gRPC proto definition. Data will not be sent. Exception: {0}", Level = EventLevel.Error)]
         public void FailedToConvertToProtoDefinitionError(string ex)
         {
@@ -60,5 +69,11 @@ public void CouldNotTranslateActivity(string className, string methodName)
         {
             this.WriteEvent(3, className, methodName);
         }
+
+        [Event(4, Message = "Unknown error in export method: {0}", Level = EventLevel.Error)]
+        public void ExportMethodException(string ex)
+        {
+            this.WriteEvent(4, ex);
+        }
     }
 }
diff --git a/src/OpenTelemetry.Exporter.OpenTelemetryProtocol/OtlpExporter.cs b/src/OpenTelemetry.Exporter.OpenTelemetryProtocol/OtlpExporter.cs
@@ -85,6 +85,12 @@ public override ExportResult Export(in Batch<Activity> activityBatch)
 
                 return ExportResult.Failure;
             }
+            catch (Exception ex)
+            {
+                OpenTelemetryProtocolExporterEventSource.Log.ExportMethodException(ex);
+
+                return ExportResult.Failure;
+            }
             finally
             {
                 request.Return();