Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch general exception in OltpExporter #1634

Merged
merged 2 commits into from
Nov 30, 2020
Merged

Catch general exception in OltpExporter #1634

merged 2 commits into from
Nov 30, 2020

Conversation

utpilla
Copy link
Contributor

@utpilla utpilla commented Nov 30, 2020

Fixes #1616

Changes

  • Catch general exception in the OltpExporter Export method

@utpilla utpilla requested a review from a team November 30, 2020 20:54
reyang
reyang approved these changes Nov 30, 2020
View reviewed changes
Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming the typo will be fixed.

@codecov
Copy link

codecov bot commented Nov 30, 2020 •
edited
Loading

Codecov Report

Merging #1634 (a0b3c26) into master (2eed6d5) will decrease coverage by 0.06%.
The diff coverage is 25.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1634      +/-   ##
==========================================
- Coverage   81.82%   81.75%   -0.07%     
==========================================
  Files         245      245              
  Lines        6579     6587       +8     
==========================================
+ Hits         5383     5385       +2     
- Misses       1196     1202       +6
Impacted Files Coverage Δ
...try.Exporter.OpenTelemetryProtocol/OtlpExporter.cs 53.65% <0.00%> (-4.24%) ⬇️
...tation/OpenTelemetryProtocolExporterEventSource.cs 50.00% <40.00%> (-3.85%) ⬇️

@cijothomas cijothomas merged commit 1630fb3 into open-telemetry:master Nov 30, 2020
@utpilla utpilla deleted the utpilla/Catch-GeneralException-OltpExporter branch November 30, 2020 22:25
@alanwest alanwest mentioned this pull request Dec 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reyang reyang reyang approved these changes

@cijothomas cijothomas cijothomas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AddOtlpExporter seems to be causing a crash?
3 participants
@utpilla @cijothomas @reyang