Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wildcard support to AddLegacySource #2183

Closed
pakrym opened this issue Jul 23, 2021 · 2 comments · Fixed by #2444
Closed

Add wildcard support to AddLegacySource #2183

pakrym opened this issue Jul 23, 2021 · 2 comments · Fixed by #2444
Labels
enhancement New feature or request help wanted Good for taking. Extra help will be provided by maintainers
Milestone

Comments

@pakrym
Copy link
Contributor

pakrym commented Jul 23, 2021

Azure SDKs produce activities that have tags and links set and don't need extra enrichment.

For client level spans we use the client and method name as activity name (i.e. BlobClient.Download) so it's impractical to use the existing AddLegacySource(string name) to collect them as customers would need to add every individual method they use.

Feature request:

Add wildcard support to AddLegacySource the same way it exists in AddSource so customers can write

.AddLegacySource("Azure.*");
@pakrym pakrym added the enhancement New feature or request label Jul 23, 2021
@pakrym
Copy link
Contributor Author

pakrym commented Jul 23, 2021

cc @cijothomas

@reyang reyang added this to the 1.2.0 milestone Jul 23, 2021
@lmolkova
Copy link

lmolkova commented Jul 24, 2021

I tried to list all possible legacy activity names.

For EventHub it's bearable:

  .AddLegacySource("EventHubs.Message")
  .AddLegacySource("EventHubProducerClient.Send")
  .AddLegacySource("EventProcessor.Process")
  .AddLegacySource("EventProcessor.Checkpoint")

But Storage does this: $"{nameof(BlobBaseClient)}.{nameof(Download)}" and it's a huge list to make. So I believe there is no workaround here.

@reyang reyang added the help wanted Good for taking. Extra help will be provided by maintainers label Sep 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Good for taking. Extra help will be provided by maintainers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants