Add basic wildcard support for listening to legacy activities. #2444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reyang
reviewed
Oct 2, 2021
reyang
reviewed
Oct 2, 2021
reyang
reviewed
Oct 2, 2021
reyang
approved these changes
Oct 2, 2021
|
@BlakeWills thanks for the contribution! Would you clear the EasyCLA so we can run the CI? |
I've followed what was already done for wildcard mode in activity sources, but there are a few questions: 1. Why do we call "Contains" instead of "EndsWith" for activity source wildcard checking? The regex only supports then end mode. 2. This doesn't support a mix, such as wanting to listen to an entire namespace of activities and then only listening to specific activities from another namespace. Again, this is consistent with current behaviour.
BlakeWills
force-pushed
the
addLegacyWildcardSupport
branch
from
77dcc98 to
8d4c639
Compare
Codecov Report
@@ Coverage Diff @@
## main #2444 +/- ##
==========================================
+ Coverage 78.31% 78.40% +0.09%
==========================================
Files 246 246
Lines 8083 8118 +35
==========================================
+ Hits 6330 6365 +35
Misses 1753 1753
|
cijothomas
approved these changes
Oct 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2183.
Changes
Add support for wildcards for legacy (DiagnosticSource) events.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes