-
Notifications
You must be signed in to change notification settings - Fork 772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add validation to instrument and view name #2470
Merged
cijothomas
merged 7 commits into
open-telemetry:main
from
dynatrace-oss-contrib:instrumentname-validation
Nov 2, 2021
Merged
Add validation to instrument and view name #2470
cijothomas
merged 7 commits into
open-telemetry:main
from
dynatrace-oss-contrib:instrumentname-validation
Nov 2, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaopgrassi
changed the title
WIP: Initial validation of instrument name
Add validation to instrument and view name
Oct 8, 2021
joaopgrassi
force-pushed
the
instrumentname-validation
branch
3 times, most recently
from
October 8, 2021 10:15
784450d
to
a456557
Compare
joaopgrassi
commented
Oct 8, 2021
Codecov Report
@@ Coverage Diff @@
## main #2470 +/- ##
==========================================
+ Coverage 80.73% 80.83% +0.10%
==========================================
Files 254 254
Lines 8516 8553 +37
==========================================
+ Hits 6875 6914 +39
+ Misses 1641 1639 -2
|
arminru
reviewed
Oct 8, 2021
reyang
reviewed
Oct 8, 2021
reyang
reviewed
Oct 8, 2021
utpilla
reviewed
Oct 9, 2021
utpilla
reviewed
Oct 9, 2021
joaopgrassi
force-pushed
the
instrumentname-validation
branch
from
October 11, 2021 10:43
af86f5e
to
e0fd3ba
Compare
I had some conflicts after #2459 but rebased and solved them now. |
cijothomas
reviewed
Oct 12, 2021
cijothomas
reviewed
Oct 12, 2021
cijothomas
reviewed
Oct 12, 2021
cijothomas
reviewed
Oct 12, 2021
cijothomas
reviewed
Oct 12, 2021
cijothomas
reviewed
Oct 12, 2021
cijothomas
reviewed
Oct 13, 2021
Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
joaopgrassi
force-pushed
the
instrumentname-validation
branch
from
October 15, 2021 07:10
aca9143
to
e3ea4f0
Compare
reyang
approved these changes
Oct 27, 2021
cijothomas
reviewed
Oct 27, 2021
cijothomas
reviewed
Oct 27, 2021
cijothomas
approved these changes
Oct 27, 2021
Rebased and fixed new conflicts. Ready to merge 😊 |
randomnoise
reviewed
Nov 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR adds validation to the instrument names as described in the Instrument spec.
Summary of changes:
AddView
that accepts thename
orMetricStreamConfiguration
fail-fast if the name provided is invalidFunc
is specified cannot be validated right away. They are only validated on instrument publish, and if invalid, are ignored with a log.OpenTelemetrySdkEventSource
to log the above casesCloses #2424
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes