Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added wildcard support for meter sources. #2459

Merged
merged 21 commits into from
Oct 9, 2021
Merged

Added wildcard support for meter sources. #2459

merged 21 commits into from
Oct 9, 2021

Conversation

Yun-Ting
Copy link
Contributor

@Yun-Ting Yun-Ting commented Oct 6, 2021 •
edited
Loading

Changes

#2377

@Yun-Ting Yun-Ting changed the title Yun ting/metricsource wildcard Added wildcard support for meter sources. Oct 6, 2021
@codecov
Copy link

codecov bot commented Oct 6, 2021 •
edited
Loading

Codecov Report

Merging #2459 (dc84c7d) into main (db8f0e7) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2459   +/-   ##
=======================================
  Coverage   79.83%   79.84%           
=======================================
  Files         254      254           
  Lines        8385     8394    +9     
=======================================
+ Hits         6694     6702    +8     
- Misses       1691     1692    +1
Impacted Files Coverage Δ
src/OpenTelemetry/Metrics/MeterProviderSdk.cs 92.08% <100.00%> (+0.30%) ⬆️
...ZPages/Implementation/ZPagesExporterEventSource.cs 56.25% <0.00%> (-6.25%) ⬇️

@Yun-Ting Yun-Ting marked this pull request as ready for review October 7, 2021 07:24
@Yun-Ting Yun-Ting requested a review from a team October 7, 2021 07:24
reyang
reyang approved these changes Oct 8, 2021
View reviewed changes
Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

cijothomas
cijothomas approved these changes Oct 9, 2021
View reviewed changes
Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
some minor comments are pending - can be follow up PR

@cijothomas cijothomas merged commit c79ad98 into open-telemetry:main Oct 9, 2021
@joaopgrassi joaopgrassi mentioned this pull request Oct 11, 2021
Merged
2 tasks
@Yun-Ting Yun-Ting mentioned this pull request Oct 11, 2021
Merged
@Yun-Ting Yun-Ting deleted the Yun-Ting/Metricsource-wildcard branch October 13, 2021 21:21
@reyang reyang mentioned this pull request Oct 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@utpilla utpilla utpilla approved these changes

@reyang reyang reyang approved these changes

@cijothomas cijothomas cijothomas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Yun-Ting @cijothomas @reyang @utpilla