Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update instrumentation libraries with latest semantic convention spec #3373

Closed
cijothomas opened this issue Jun 16, 2022 · 2 comments
Closed
Assignees

Comments

@cijothomas
Copy link
Member

Most of the instrumentation libraries were written when semantic conventions were in early stages, and a lot changes have occurred since then. Opening an issue to track updating instrumentation libraries in this repo (httpclients,aspnetcore,sqlclient,grpc), to match the latest spec.

An open question, which is to be discussed: How much control these instrumentations offer to user for turning on/off individual tags? Do we want a turn on/off flag for each tag? Like https://github.com/open-telemetry/opentelemetry-dotnet/blob/main/src/OpenTelemetry.Instrumentation.Http/HttpClientInstrumentationOptions.cs#L34.

or a set of tags? What is the criteria to make that decision (perf/security/privacy/spec-recommendedvsrequiresvsoption)

@cijothomas
Copy link
Member Author

https://docs.microsoft.com/en-us/aspnet/core/fundamentals/http-logging/?view=aspnetcore-6.0 Might be able to borrow some ideas from this, regd. what tags gets populated / not.

@vishweshbankwar
Copy link
Member

closing this as the changes are tracked with #4484

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants