Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ASP.NET Core] Remove http.host and add net.host.name and net.host.port #3858

Conversation

vishweshbankwar
Copy link
Member

@vishweshbankwar vishweshbankwar commented Nov 2, 2022

Towards #3373

Changes

Spec: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/semantic_conventions/http.md#http-server-semantic-conventions

For significant contributions please make sure you have completed the following items:

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #
  • Changes in public API reviewed

@codecov
Copy link

codecov bot commented Nov 2, 2022

Codecov Report

Merging #3858 (f3f1516) into main (e0d8737) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3858      +/-   ##
==========================================
+ Coverage   87.33%   87.34%   +0.01%     
==========================================
  Files         279      279              
  Lines       10810    10811       +1     
==========================================
+ Hits         9441     9443       +2     
+ Misses       1369     1368       -1     
Impacted Files Coverage Δ
...tation.AspNetCore/Implementation/HttpInListener.cs 90.30% <100.00%> (+0.05%) ⬆️
...ZPages/Implementation/ZPagesExporterEventSource.cs 62.50% <0.00%> (+6.25%) ⬆️

@vishweshbankwar vishweshbankwar marked this pull request as ready for review November 10, 2022 22:12
@vishweshbankwar vishweshbankwar requested a review from a team November 10, 2022 22:12
@cijothomas cijothomas merged commit 459e2d7 into open-telemetry:main Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants