-
Notifications
You must be signed in to change notification settings - Fork 772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ASP.NET Core] Remove http.host
and add net.host.name
and net.host.port
#3858
Merged
cijothomas
merged 19 commits into
open-telemetry:main
from
vishweshbankwar:vibankwa/replace-httphost-to-net-host-name-net-host-port
Nov 17, 2022
Merged
[ASP.NET Core] Remove http.host
and add net.host.name
and net.host.port
#3858
cijothomas
merged 19 commits into
open-telemetry:main
from
vishweshbankwar:vibankwa/replace-httphost-to-net-host-name-net-host-port
Nov 17, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3858 +/- ##
==========================================
+ Coverage 87.33% 87.34% +0.01%
==========================================
Files 279 279
Lines 10810 10811 +1
==========================================
+ Hits 9441 9443 +2
+ Misses 1369 1368 -1
|
…t' of https://github.com/vishweshbankwar/opentelemetry-dotnet into vibankwa/replace-httphost-to-net-host-name-net-host-port
Kielek
approved these changes
Nov 14, 2022
cijothomas
reviewed
Nov 14, 2022
src/OpenTelemetry.Instrumentation.AspNetCore/Implementation/HttpInListener.cs
Outdated
Show resolved
Hide resolved
cijothomas
approved these changes
Nov 14, 2022
cijothomas
reviewed
Nov 16, 2022
cijothomas
reviewed
Nov 17, 2022
src/OpenTelemetry.Instrumentation.AspNetCore/Implementation/HttpInListener.cs
Outdated
Show resolved
Hide resolved
…t' of https://github.com/vishweshbankwar/opentelemetry-dotnet into vibankwa/replace-httphost-to-net-host-name-net-host-port
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #3373
Changes
Spec: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/semantic_conventions/http.md#http-server-semantic-conventions
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes