-
Notifications
You must be signed in to change notification settings - Fork 772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better handling of OTLP proto sources #652
Comments
So I've got a change that swaps out the protos with files from a git submodule but I don't know how to incorporate this into the ci workflows. A basic clone of the repo won't pull submodules by default (I think). You would need to specify the --recursive flag to the step in some way. @eddynaka Do you know offhand what additional changes would have to be done? Here is my branch with the change: After checking this in, developers with existing repos would also have to do:
Otherwise, the submodule files won't be there. |
Talked with @pcwiese offline, but, GitHub actions does support that: https://github.com/actions/checkout We have to add:
|
We are not going to use Git submodules for this. if we need to, we can create a NuGet package |
I think this is pretty solid now, and I'm not sure there are intentions to do anything else. I'd suggest reopening this if you feel there is a need to do this with some more up to date reasoning. |
Separating this from the discussion at #19
Currently, the proto files are copied to the OTLP exporter sources. At this stage I see two possible options:
The text was updated successfully, but these errors were encountered: