-
Notifications
You must be signed in to change notification settings - Fork 772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OTLP Exporter] Configurable gRPC ChannelOptions #1033
[OTLP Exporter] Configurable gRPC ChannelOptions #1033
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1033 +/- ##
==========================================
- Coverage 77.12% 77.06% -0.07%
==========================================
Files 221 221
Lines 6155 6156 +1
==========================================
- Hits 4747 4744 -3
- Misses 1408 1412 +4
|
@pcwiese I'm not at all familiar with gRPC. Are there many more options than what we currently expose? I kind of like the Func idea, especially if there are a lot of other things that can be configured. Aso, we should probably note in CHANGELOG. |
There are a ton of options and the way this PR is passing them through is completely fine as is. Take a look at https://grpc.github.io/grpc/cpp/grpc__types_8h.html for the entire defined set. Each channel option is just setting one of the GRPC_ARG* values |
We need to allow users to configure channel options for the OTLP exporter.
Another option here is to ditch the various options specific to creating a channel and just expose Func<Channel> in the options. Let consumers do whatever they want when constructing the Channel. I might like that better...