Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renaming from OT to OTel #1046

Merged
merged 5 commits into from
Aug 12, 2020
Merged

Renaming from OT to OTel #1046

merged 5 commits into from
Aug 12, 2020

Conversation

eddynaka
Copy link
Contributor

Fixes #1042.

Changes

Please provide a brief description of the changes here. Update the
CHANGELOG.md for non-trivial changes.

For significant contributions please make sure you have completed the following items:

  • Design discussion issue #
  • Changes in public API reviewed

@eddynaka eddynaka requested a review from a team August 11, 2020 15:02
reyang
reyang approved these changes Aug 11, 2020
View reviewed changes
Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@codecov
Copy link

codecov bot commented Aug 11, 2020 •
edited
Loading

Codecov Report

Merging #1046 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1046      +/-   ##
==========================================
+ Coverage   77.08%   77.13%   +0.04%     
==========================================
  Files         221      221              
  Lines        6092     6092              
==========================================
+ Hits         4696     4699       +3     
+ Misses       1396     1393       -3
Impacted Files Coverage Δ
src/OpenTelemetry.Api/Trace/ActivityExtensions.cs 100.00% <ø> (ø)
...xporter.Prometheus/PrometheusExporterExtensions.cs 82.81% <ø> (ø)
src/OpenTelemetry/Trace/ActivityExtensions.cs 80.00% <ø> (ø)
...us/Implementation/PrometheusExporterEventSource.cs 63.63% <0.00%> (-9.10%) ⬇️
src/OpenTelemetry/Metrics/CounterMetricSdkBase.cs 96.66% <0.00%> (+13.33%) ⬆️

@eddynaka
Copy link
Contributor Author

LGTM.

@reyang , just updated everything. Can you re-review?

@cijothomas cijothomas merged commit dad644a into open-telemetry:master Aug 12, 2020
@eddynaka eddynaka deleted the feature/renaming-ot branch August 14, 2020 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reyang reyang reyang approved these changes

@rajkumar-rangaraj rajkumar-rangaraj rajkumar-rangaraj approved these changes

@cijothomas cijothomas cijothomas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename "ot" to "otel"
4 participants
@eddynaka @cijothomas @rajkumar-rangaraj @reyang