Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor exporter - step 5 #1087

Merged
merged 9 commits into from
Aug 16, 2020
Merged

Refactor exporter - step 5 #1087

merged 9 commits into from
Aug 16, 2020

Conversation

reyang
Copy link
Member

@reyang reyang commented Aug 16, 2020

This is a follow up PR of #1078.

Changes

  • Added Ingress and Egress internal properties to the circular buffer, which would be useful for internal logging.
  • Integrated circular buffer to BatchExportActivityProcessor.

For significant contributions please make sure you have completed the following items:

  • Design discussion issue #
  • Changes in public API reviewed

@reyang reyang requested a review from a team August 16, 2020 05:20
@codecov
Copy link

codecov bot commented Aug 16, 2020

Codecov Report

Merging #1087 into master will decrease coverage by 0.15%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1087      +/-   ##
==========================================
- Coverage   76.17%   76.01%   -0.16%     
==========================================
  Files         225      225              
  Lines        6199     6208       +9     
==========================================
- Hits         4722     4719       -3     
- Misses       1477     1489      +12     
Impacted Files Coverage Δ
src/OpenTelemetry/Internal/CircularBuffer.cs 0.00% <0.00%> (ø)
...penTelemetry/Trace/BatchExportActivityProcessor.cs 0.00% <0.00%> (ø)
...us/Implementation/PrometheusExporterEventSource.cs 63.63% <0.00%> (-9.10%) ⬇️
...nTelemetry/Internal/OpenTelemetrySdkEventSource.cs 79.41% <0.00%> (-2.95%) ⬇️

@CodeBlanch
Copy link
Member

It is probably more .NET-y to use AddedCount, RemovedCount, and DroppedCount (or simiar) as the names for ingress, egress, & regress.

@reyang
Copy link
Member Author

reyang commented Aug 16, 2020

It is probably more .NET-y to use AddedCount, RemovedCount, and DroppedCount (or similar) as the names for ingress, egress, & regress.

I've updated the names. Please take a look.

Initially I was thinking to use these abstract names to unify the queue/process/exporter (e.g. queue would have AddedCount/EnqueuedCount, RemovedCount/DequeuedCount; processor would have ReceivedCount, ProcessedCount and DroppedCount; exporter would have ReceivedCount, DroppedCount (in case of bad data) and ExportedCount).

@CodeBlanch CodeBlanch merged commit ec5683a into master Aug 16, 2020
@CodeBlanch CodeBlanch deleted the reyang/exporter5 branch August 16, 2020 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants