-
Notifications
You must be signed in to change notification settings - Fork 772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor exporter - step 10 #1135
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1135 +/- ##
==========================================
- Coverage 77.28% 77.23% -0.05%
==========================================
Files 220 220
Lines 6260 6269 +9
==========================================
+ Hits 4838 4842 +4
- Misses 1422 1427 +5
|
/// </summary> | ||
public virtual void Shutdown() | ||
/// <param name="timeoutMillis"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Should we spell it out fully timeoutMilliseconds
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That name is coming from the spec.
@cijothomas if we want be C# idiomatic, I will use timeoutMilliseconds
across the entire repo (current many places are already using the timeoutMillis
convention from the spec.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've changed all places to use timeoutMilliseconds
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just the one nit on timeoutMillis name.
This PR concludes #1078.
Changes
Shutdown
andForceFlush
.For significant contributions please make sure you have completed the following items: