-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename gRPC instrumentation project #1136
Rename gRPC instrumentation project #1136
Conversation
@@ -1,6 +1,6 @@ | |||
<Project Sdk="Microsoft.NET.Sdk"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left the name of this test project the same since it has tests for both Grpc.Net.Client and Grpc.AspNetCore. Open to conversation here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, the top level README might need to be updated since it has links to this project (docfx CI will catch it).
Where do we document this in changelog? |
I guess in the release notes. |
@alanwest Can you add an entry in the new changelog.md to say this package is the renamed version of the |
…metry-dotnet into alanwest/grpc-project
@alanwest LGTM - there is a build failure due to renaming . Please fix that and we are good to merge |
Codecov Report
@@ Coverage Diff @@
## master #1136 +/- ##
==========================================
- Coverage 77.28% 77.25% -0.04%
==========================================
Files 220 220
Lines 6269 6269
==========================================
- Hits 4845 4843 -2
- Misses 1424 1426 +2
|
Fixes #1130.
Changes
Please provide a brief description of the changes here. Update the
CHANGELOG.md
for non-trivial changes.For significant contributions please make sure you have completed the following items: