Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename gRPC instrumentation project #1136

Merged
merged 12 commits into from
Aug 22, 2020

Conversation

alanwest
Copy link
Member

Fixes #1130.

Changes

Please provide a brief description of the changes here. Update the
CHANGELOG.md for non-trivial changes.

For significant contributions please make sure you have completed the following items:

  • Design discussion issue #
  • Changes in public API reviewed

@alanwest alanwest requested a review from a team August 21, 2020 22:38
@@ -1,6 +1,6 @@
<Project Sdk="Microsoft.NET.Sdk">
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left the name of this test project the same since it has tests for both Grpc.Net.Client and Grpc.AspNetCore. Open to conversation here.

@alanwest alanwest changed the title Alanwest/grpc project Rename gRPR instrumentation project Aug 21, 2020
@alanwest alanwest changed the title Rename gRPR instrumentation project Rename gRPC instrumentation project Aug 21, 2020
Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the top level README might need to be updated since it has links to this project (docfx CI will catch it).

@cijothomas
Copy link
Member

Where do we document this in changelog?

@reyang
Copy link
Member

reyang commented Aug 21, 2020

Where do we document this in changelog?

I guess in the release notes.

@cijothomas
Copy link
Member

@alanwest Can you add an entry in the new changelog.md to say this package is the renamed version of the

@cijothomas
Copy link
Member

@alanwest LGTM - there is a build failure due to renaming . Please fix that and we are good to merge

@codecov
Copy link

codecov bot commented Aug 22, 2020

Codecov Report

Merging #1136 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1136      +/-   ##
==========================================
- Coverage   77.28%   77.25%   -0.04%     
==========================================
  Files         220      220              
  Lines        6269     6269              
==========================================
- Hits         4845     4843       -2     
- Misses       1424     1426       +2     
Impacted Files Coverage Δ
...tation.AspNetCore/Implementation/HttpInListener.cs 89.13% <ø> (ø)
...ntation.GrpcNetClient/GrpcClientInstrumentation.cs 87.50% <ø> (ø)
...try.Instrumentation.GrpcNetClient/GrpcTagHelper.cs 100.00% <ø> (ø)
...ent/Implementation/GrpcClientDiagnosticListener.cs 89.65% <ø> (ø)
...t/Implementation/GrpcInstrumentationEventSource.cs 100.00% <ø> (ø)
...on.GrpcNetClient/Implementation/PropertyFetcher.cs 82.60% <ø> (ø)
...n.GrpcNetClient/TracerProviderBuilderExtensions.cs 100.00% <ø> (ø)
...ZPages/Implementation/ZPagesExporterEventSource.cs 56.25% <0.00%> (-6.25%) ⬇️
...nTelemetry/Internal/OpenTelemetrySdkEventSource.cs 77.77% <0.00%> (-3.18%) ⬇️
...mentation.Http/HttpClientInstrumentationOptions.cs 100.00% <0.00%> (+4.16%) ⬆️

@cijothomas cijothomas merged commit 0f618d0 into open-telemetry:master Aug 22, 2020
@alanwest alanwest deleted the alanwest/grpc-project branch August 24, 2020 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename OpenTelemetry.Instrumentation.Grpc to OpenTelemetry.Instrumentation.GrpcClient
4 participants