Update diagnosticsource to rc1 #1203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1203 +/- ##
==========================================
+ Coverage 78.73% 78.76% +0.03%
==========================================
Files 219 219
Lines 6300 6296 -4
==========================================
- Hits 4960 4959 -1
+ Misses 1340 1337 -3
|
lmolkova
reviewed
Aug 31, 2020
| options.Name, | ||
| options.Kind, | ||
| options.Tags, | ||
| options.Links); | ||
|
|
||
| var shouldSample = sampler.ShouldSample(samplingParameters); | ||
|
|
||
| var activityDataRequest = shouldSample.Decision switch | ||
| var activitySamplingResult = shouldSample.Decision switch |
There was a problem hiding this comment.
would this callback be called for legacy (http-in/out) DiagnosticSource instrumentations?
There was a problem hiding this comment.
Good point!
I missed it. Let me add it to the other refactor on ActivitySourceAdapter (which deals with Activity created using DiagnosticSource methods)
Tracking here #1210
CodeBlanch
reviewed
Sep 1, 2020
| @@ -6,6 +6,7 @@ | |||
| <!-- | |||
| <add key="Dotnet5" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet5/nuget/v3/index.json" /> | |||
| --> | |||
| <add key="Dotnet5" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet5/nuget/v3/index.json" /> | |||
There was a problem hiding this comment.
nit: Looks like the same entry is right above the new one (commented out).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1212
Fixes #953
Lot of renamings.
Remove AutoGenerateRootContextTraceId as TraceId is always passed as additional parameter to Sample.
Attributes returned by Sampler are added to the Activity, if it gets created with all data.
Special thanks to Eddy who helped with Propagators test issues.
TODO (In separate PR)
Fix for 953 for legacy instrumentations. ActivitySourceAdapter must be changed to reflect the new capabilities. This will be addressed along with #1210 as an immediate follow up to this PR.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes