Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.NET 5 package downgrade warning/error #1272

Merged

Conversation

CodeBlanch
Copy link
Member

I started getting a package downgrade warning after the .NET 5 RC1 upgrade (#1265) on the System.Runtime.CompilerServices.Unsafe package ref in the Examples.AspNet app. I removed the reference and it seems to build & run fine.

@CodeBlanch CodeBlanch requested a review from a team September 16, 2020 00:35
Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@codecov
Copy link

codecov bot commented Sep 16, 2020

Codecov Report

Merging #1272 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1272   +/-   ##
=======================================
  Coverage   79.08%   79.08%           
=======================================
  Files         215      215           
  Lines        6174     6174           
=======================================
  Hits         4883     4883           
  Misses       1291     1291           
Impacted Files Coverage Δ
...us/Implementation/PrometheusExporterEventSource.cs 63.63% <0.00%> (-9.10%) ⬇️
...ZPages/Implementation/ZPagesExporterEventSource.cs 62.50% <0.00%> (+6.25%) ⬆️

@cijothomas cijothomas merged commit 4d2ed9f into open-telemetry:master Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants