Add AWS X-Ray Propagator #1300
Add AWS X-Ray Propagator #1300
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1300 +/- ##
==========================================
+ Coverage 77.88% 78.62% +0.73%
==========================================
Files 226 220 -6
Lines 6386 6387 +1
==========================================
+ Hits 4974 5022 +48
+ Misses 1412 1365 -47
|
| return false; | ||
| } | ||
|
|
||
| var activityTraceId = ActivityTraceId.CreateFromString(traceId.AsSpan()); |
There was a problem hiding this comment.
Lots of string manipulation above to pass a span here. If you switch the above code to manipulate spans over the string/char[] it will probably be less memory instensive/faster overall.
There was a problem hiding this comment.
Just switched from manipulating String to ReadOnlySpan in the latest version
|
I know I'm risking "lost" packages here (😄), but I want to ask: Would this be better in the contrib repo? This part of the spec seems to be saying we shouldn't have vendor-specific propagators in the main repo: |
That's what we're thinking previously, but in Java seems like it's keeping all propagators in the same place and that's why we put it in the main repo. Also, as we're using interface from OT SDK, how can we do that in contrib repo in this case, suggestions would be much appreciated! :) Update: Seems like there is an agreement about where to put the vendor-specific propagators, and turns out it should be in the main repo. Let's wait for @cijothomas 's clarification. |
|
open-telemetry/opentelemetry-specification#1043 Once this spec PR is merged, we can officially confirm that vendor specific propagators can be hosted in the main repo itself. |
|
Moving from main repo to contrib repo |
Changes
Added support for propagating AWS X-Ray trace header.