Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ILogger integration - part 1 #1308

Merged
merged 4 commits into from
Sep 25, 2020
Merged

ILogger integration - part 1 #1308

merged 4 commits into from
Sep 25, 2020

Conversation

reyang
Copy link
Member

@reyang reyang commented Sep 25, 2020 •
edited
Loading

The 1st PR on ILogger integration.

Will explore the following things in subsequent PRs:

  • Processor/Sampler.
  • Exporter interface.
  • Integration with trace id and span id.
  • Integration with context/baggage.

Changes

  • Added basic skeleton - logger, logger provider, logger options.
  • Added a tutorial project.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #
  • Changes in public API reviewed

@reyang reyang requested a review from a team September 25, 2020 18:23
@reyang reyang changed the title Ilogger integration Ilogger integration - part 1 Sep 25, 2020
@reyang reyang changed the title Ilogger integration - part 1 ILogger integration - part 1 Sep 25, 2020
@codecov
Copy link

codecov bot commented Sep 25, 2020 •
edited
Loading

Codecov Report

Merging #1308 into master will decrease coverage by 0.58%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1308      +/-   ##
==========================================
- Coverage   79.15%   78.56%   -0.59%     
==========================================
  Files         216      219       +3     
  Lines        6188     6237      +49     
==========================================
+ Hits         4898     4900       +2     
- Misses       1290     1337      +47
Impacted Files Coverage Δ
src/OpenTelemetry/Logs/OpenTelemetryLogger.cs 0.00% <0.00%> (ø)
.../OpenTelemetry/Logs/OpenTelemetryLoggerProvider.cs 0.00% <0.00%> (ø)
...enTelemetry/Logs/OpenTelemetryLoggingExtensions.cs 0.00% <0.00%> (ø)
...nTelemetry/Internal/OpenTelemetrySdkEventSource.cs 80.95% <0.00%> (+3.17%) ⬆️

CodeBlanch
CodeBlanch approved these changes Sep 25, 2020
View reviewed changes
Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cijothomas cijothomas merged commit 6529c43 into master Sep 25, 2020
@cijothomas cijothomas deleted the reyang/logs branch September 25, 2020 21:32
This was referenced Sep 26, 2020
Merged
Merged
This was referenced Oct 7, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CodeBlanch CodeBlanch CodeBlanch approved these changes

@cijothomas cijothomas cijothomas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@reyang @cijothomas @CodeBlanch