-
Notifications
You must be signed in to change notification settings - Fork 774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Activity.EnumerateLinks extension #1314
Added Activity.EnumerateLinks extension #1314
Conversation
/// </summary> | ||
public interface IActivityTagEnumerator | ||
/// <typeparam name="T">Enumerated item type.</typeparam> | ||
public interface IActivityEnumerator<T> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I switched IActivityTagEnumerator
to IActivityEnumerator<T>
so I could use it for tags, links, and events (up next). Breaking change, which is a con, but pro is with this change we don't need a bunch of interfaces that are basically the same, just different item types.
Codecov Report
@@ Coverage Diff @@
## master #1314 +/- ##
==========================================
+ Coverage 78.51% 78.63% +0.11%
==========================================
Files 219 219
Lines 6243 6253 +10
==========================================
+ Hits 4902 4917 +15
+ Misses 1341 1336 -5
|
@eddynaka @cijothomas Just updated branch and I'm getting a strange, seemingly unrelated, test failure:
Any idea what might be causing that? |
It's an order issue. I couldn't find a way to trigger. but sometimes happens. |
Added an extension method for enumerating Activity Links without an allocation. Updated Jaeger to use it.
TODOs:
CHANGELOG.md
updated for non-trivial changes