Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating DiagnosticSource to version 5.0.0-rc.2.20475.5 #1346

Merged
merged 2 commits into from
Oct 13, 2020
Merged

Updating DiagnosticSource to version 5.0.0-rc.2.20475.5 #1346

merged 2 commits into from
Oct 13, 2020

Conversation

eddynaka
Copy link
Contributor

Fixes #.

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #
  • Changes in public API reviewed

@eddynaka eddynaka requested a review from a team October 13, 2020 18:35
Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@codecov
Copy link

codecov bot commented Oct 13, 2020

Codecov Report

Merging #1346 into master will decrease coverage by 0.28%.
The diff coverage is 92.68%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1346      +/-   ##
==========================================
- Coverage   77.88%   77.60%   -0.29%     
==========================================
  Files         226      226              
  Lines        6386     6314      -72     
==========================================
- Hits         4974     4900      -74     
- Misses       1412     1414       +2     
Impacted Files Coverage Δ
...tation.AspNetCore/Implementation/HttpInListener.cs 87.50% <ø> (-0.12%) ⬇️
...ent/Implementation/GrpcClientDiagnosticListener.cs 83.33% <ø> (-0.46%) ⬇️
...tp/Implementation/HttpHandlerDiagnosticListener.cs 78.82% <25.00%> (ø)
src/OpenTelemetry.Api/Trace/ActivityExtensions.cs 99.12% <100.00%> (+0.03%) ⬆️
src/OpenTelemetry.Api/Trace/SpanHelper.cs 100.00% <100.00%> (+1.38%) ⬆️
src/OpenTelemetry.Api/Trace/Status.cs 100.00% <100.00%> (ø)
...metryProtocol/Implementation/ActivityExtensions.cs 90.34% <100.00%> (ø)
...try.Instrumentation.GrpcNetClient/GrpcTagHelper.cs 100.00% <100.00%> (ø)
...ient/Implementation/SqlClientDiagnosticListener.cs 75.36% <100.00%> (ø)
...mentation/RedisProfilerEntryToActivityConverter.cs 94.59% <100.00%> (ø)
... and 5 more

@cijothomas cijothomas closed this Oct 13, 2020
@cijothomas cijothomas reopened this Oct 13, 2020
@cijothomas cijothomas merged commit 5c85552 into open-telemetry:master Oct 13, 2020
@eddynaka eddynaka deleted the feature/updating-to-officla-rc2 branch October 17, 2020 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants