Enable OnException for AspNetCore instrumentation

src/OpenTelemetry.Instrumentation.AspNetCore/AspNetCoreInstrumentationOptions.cs

@@ -53,5 +53,10 @@ public class AspNetCoreInstrumentationOptions
         /// The type of this object depends on the event, which is given by the above parameter.</para>
         /// </remarks>
         public Action<Activity, string, object> Enrich { get; set; }
+
+        /// <summary>
+        /// Gets or sets a value indicating whether the exception will be recorded or not.
+        /// </summary>
+        public bool RecordException { get; set; }
     }
 }

src/OpenTelemetry.Instrumentation.AspNetCore/CHANGELOG.md

@@ -2,6 +2,10 @@
 
 ## Unreleased
 
+* Record `Exception` in AspNetCore instrumentation based on `RecordException` in
+  `AspNetCoreInstrumentationOptions`
+  ([#1408](https://github.com/open-telemetry/opentelemetry-dotnet/issues/1408))
+
 ## 0.7.0-beta.1
 
 Released 2020-Oct-16

src/OpenTelemetry.Instrumentation.AspNetCore/Implementation/HttpInListener.cs

@@ -34,6 +34,7 @@ internal class HttpInListener : ListenerHandler
         private static readonly Func<HttpRequest, string, IEnumerable<string>> HttpRequestHeaderValuesGetter = (request, name) => request.Headers[name];
         private readonly PropertyFetcher<HttpContext> startContextFetcher = new PropertyFetcher<HttpContext>("HttpContext");
         private readonly PropertyFetcher<HttpContext> stopContextFetcher = new PropertyFetcher<HttpContext>("HttpContext");
+        private readonly PropertyFetcher<Exception> stopExceptionFetcher = new PropertyFetcher<Exception>("Exception");
         private readonly PropertyFetcher<object> beforeActionActionDescriptorFetcher = new PropertyFetcher<object>("actionDescriptor");
         private readonly PropertyFetcher<object> beforeActionAttributeRouteInfoFetcher = new PropertyFetcher<object>("AttributeRouteInfo");
         private readonly PropertyFetcher<string> beforeActionTemplateFetcher = new PropertyFetcher<string>("Template");
@@ -225,6 +226,30 @@ public override void OnCustom(string name, Activity activity, object payload)
             }
         }
 
+        public override void OnException(Activity activity, object payload)
+        {
+            if (activity.IsAllDataRequested && this.options.RecordException)
+            {
+                if (!this.stopExceptionFetcher.TryFetch(payload, out Exception exc) || exc == null)
+                {
+                    AspNetCoreInstrumentationEventSource.Log.NullPayload(nameof(HttpInListener), nameof(this.OnException));
+                    return;
+                }
+
+                try
+                {
+                    this.options.Enrich?.Invoke(activity, "OnException", exc);
+                }
+                catch (Exception ex)
+                {
+                    AspNetCoreInstrumentationEventSource.Log.EnrichmentException(ex);
+                }
+
+                activity.RecordException(exc);
+                activity.SetStatus(Status.Error.WithDescription(exc.Message));
+            }
+        }
+
         private static string GetUri(HttpRequest request)
         {
             var builder = new StringBuilder();

src/OpenTelemetry.Instrumentation.Http/CHANGELOG.md

@@ -5,7 +5,7 @@
 * Instrumentation for `HttpWebRequest` no longer store raw objects like
   `HttpWebRequest` in Activity.CustomProperty. To enrich activity, use the
   Enrich action on the instrumentation.
-  ([#1261](https://github.com/open-telemetry/opentelemetry-dotnet/pull/1407))
+  ([#1407](https://github.com/open-telemetry/opentelemetry-dotnet/pull/1407))
 
 ## 0.7.0-beta.1
 

src/OpenTelemetry.Instrumentation.Http/Implementation/HttpHandlerDiagnosticListener.cs

@@ -184,6 +184,8 @@ public override void OnException(Activity activity, object payload)
                     HttpInstrumentationEventSource.Log.EnrichmentException(ex);
                 }
 
+                activity.RecordException(exc);
+
                 if (exc is HttpRequestException)
                 {
                     if (exc.InnerException is SocketException exception)