-
Notifications
You must be signed in to change notification settings - Fork 772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added ServiceName option to OtlpExporter #1420
Added ServiceName option to OtlpExporter #1420
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1420 +/- ##
==========================================
+ Coverage 81.31% 81.87% +0.56%
==========================================
Files 227 227
Lines 6117 6086 -31
==========================================
+ Hits 4974 4983 +9
+ Misses 1143 1103 -40
|
@eddynaka @cijothomas Would you guys mind taking another look at this? In order to make the tests work I had to switch the resource from a static on |
@CodeBlanch , took a look. Looks fine. Don't think that will affect performance/allocation much. |
Fixes #1416
Changes
Add
ServiceName
option to OtlpExporter to bring it into parity with Zipkin & Jaeger.TODOs:
CHANGELOG.md
updated for non-trivial changes