Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving grpc status and helper to grpc project #1422

Merged
merged 5 commits into from
Oct 30, 2020
Merged

Moving grpc status and helper to grpc project #1422

merged 5 commits into from
Oct 30, 2020

Conversation

eddynaka
Copy link
Contributor

Fixes #.

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #
  • Changes in public API reviewed

@eddynaka eddynaka requested a review from a team October 29, 2020 19:00
@eddynaka eddynaka self-assigned this Oct 29, 2020
@codecov
Copy link

codecov bot commented Oct 29, 2020

Codecov Report

Merging #1422 into master will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1422      +/-   ##
==========================================
+ Coverage   81.84%   81.89%   +0.04%     
==========================================
  Files         227      227              
  Lines        6086     6086              
==========================================
+ Hits         4981     4984       +3     
+ Misses       1105     1102       -3     
Impacted Files Coverage Δ
src/OpenTelemetry.Api/Trace/SpanHelper.cs 100.00% <ø> (ø)
...try.Instrumentation.GrpcNetClient/GrpcTagHelper.cs 100.00% <100.00%> (ø)
...nTelemetry/Internal/OpenTelemetrySdkEventSource.cs 75.34% <0.00%> (+1.36%) ⬆️
...ter.ZPages/Implementation/ZPagesActivityTracker.cs 100.00% <0.00%> (+2.85%) ⬆️
...ZPages/Implementation/ZPagesExporterEventSource.cs 62.50% <0.00%> (+6.25%) ⬆️

Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One less public API!

@cijothomas cijothomas merged commit 5205d05 into open-telemetry:master Oct 30, 2020
@eddynaka eddynaka deleted the feature/moving-grpc-status-grpcproject branch November 3, 2020 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants