-
Notifications
You must be signed in to change notification settings - Fork 774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SpanAttributeConstants is internal #1457
SpanAttributeConstants is internal #1457
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1457 +/- ##
==========================================
+ Coverage 81.67% 81.94% +0.27%
==========================================
Files 229 229
Lines 6095 6143 +48
==========================================
+ Hits 4978 5034 +56
+ Misses 1117 1109 -8
|
fixing tests Revert "fixing tests" This reverts commit 66167c899025f2e56aca957bbcbe6d658a866d17.
@@ -19,7 +19,7 @@ namespace OpenTelemetry.Trace | |||
/// <summary> | |||
/// Defines well-known span attribute keys. | |||
/// </summary> | |||
public static class SpanAttributeConstants | |||
internal static class SpanAttributeConstants |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i am wondering why is the instrumentation populating those tags which are not part of semantic convention? we can eliminate that, and then eliminate the need for this at all.
(Lets address it separately, Okay to merge this)
Fixes #.
Changes
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes