Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SpanAttributeConstants is internal #1457

Merged
merged 5 commits into from
Nov 4, 2020
Merged

SpanAttributeConstants is internal #1457

merged 5 commits into from
Nov 4, 2020

Conversation

eddynaka
Copy link
Contributor

@eddynaka eddynaka commented Nov 4, 2020

Fixes #.

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #
  • Changes in public API reviewed

@codecov
Copy link

codecov bot commented Nov 4, 2020

Codecov Report

Merging #1457 into master will increase coverage by 0.27%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1457      +/-   ##
==========================================
+ Coverage   81.67%   81.94%   +0.27%     
==========================================
  Files         229      229              
  Lines        6095     6143      +48     
==========================================
+ Hits         4978     5034      +56     
+ Misses       1117     1109       -8     
Impacted Files Coverage Δ
...lemetry/Internal/SelfDiagnosticsConfigRefresher.cs 0.00% <0.00%> (ø)
...Telemetry/Internal/SelfDiagnosticsEventListener.cs 90.90% <91.30%> (+90.90%) ⬆️
...ter.ZPages/Implementation/ZPagesActivityTracker.cs 100.00% <0.00%> (+2.85%) ⬆️
...ZPages/Implementation/ZPagesExporterEventSource.cs 62.50% <0.00%> (+6.25%) ⬆️
...emetry.Api/Internal/OpenTelemetryApiEventSource.cs 82.35% <0.00%> (+8.82%) ⬆️
...us/Implementation/PrometheusExporterEventSource.cs 72.72% <0.00%> (+9.09%) ⬆️

@eddynaka eddynaka marked this pull request as ready for review November 4, 2020 14:25
@eddynaka eddynaka requested a review from a team November 4, 2020 14:25
fixing tests

Revert "fixing tests"

This reverts commit 66167c899025f2e56aca957bbcbe6d658a866d17.
@eddynaka eddynaka self-assigned this Nov 4, 2020
@@ -19,7 +19,7 @@ namespace OpenTelemetry.Trace
/// <summary>
/// Defines well-known span attribute keys.
/// </summary>
public static class SpanAttributeConstants
internal static class SpanAttributeConstants
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i am wondering why is the instrumentation populating those tags which are not part of semantic convention? we can eliminate that, and then eliminate the need for this at all.

(Lets address it separately, Okay to merge this)

@cijothomas cijothomas merged commit 356c409 into open-telemetry:master Nov 4, 2020
@eddynaka eddynaka deleted the feature/SpanAttributeConstants-internal branch November 6, 2020 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants