Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Activity.IsRecorded check for Export #1574

Merged
merged 6 commits into from
Nov 18, 2020
Merged

Added Activity.IsRecorded check for Export #1574

merged 6 commits into from
Nov 18, 2020

Conversation

utpilla
Copy link
Contributor

@utpilla utpilla commented Nov 18, 2020

Fixes #1558

Changes

  • Added a check for ActivityTraceFlags for export

@utpilla utpilla requested a review from a team November 18, 2020 00:40
@codecov
Copy link

codecov bot commented Nov 18, 2020 •
edited
Loading

Codecov Report

Merging #1574 (b815f55) into master (9e90fce) will decrease coverage by 0.82%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1574      +/-   ##
==========================================
- Coverage   81.51%   80.68%   -0.83%     
==========================================
  Files         237      241       +4     
  Lines        6449     6525      +76     
==========================================
+ Hits         5257     5265       +8     
- Misses       1192     1260      +68
Impacted Files Coverage Δ
src/OpenTelemetry/BatchExportProcessor.cs 93.05% <ø> (ø)
src/OpenTelemetry/SimpleExportProcessor.cs 70.00% <ø> (ø)
src/OpenTelemetry/BaseExportProcessor.cs 85.71% <100.00%> (+3.36%) ⬆️
...porter.Console/ConsoleExporterLoggingExtensions.cs 0.00% <0.00%> (ø)
.../OpenTelemetry.Exporter.Console/ConsoleExporter.cs 4.91% <0.00%> (ø)
...lemetry.Exporter.Console/ConsoleExporterOptions.cs 100.00% <0.00%> (ø)
...xporter.Console/ConsoleExporterHelperExtensions.cs 0.00% <0.00%> (ø)

reyang
reyang approved these changes Nov 18, 2020
View reviewed changes
Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@cijothomas cijothomas merged commit b247b3d into open-telemetry:master Nov 18, 2020
@utpilla utpilla mentioned this pull request Nov 25, 2020
Merged
@utpilla utpilla deleted the utpilla/Add-IsRecorded-Check-For-Export branch November 30, 2020 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CodeBlanch CodeBlanch CodeBlanch left review comments

@cijothomas cijothomas cijothomas approved these changes

@reyang reyang reyang approved these changes

@eddynaka eddynaka eddynaka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ActivityExporter is called even if Activity.Recorded is false.
5 participants
@utpilla @cijothomas @eddynaka @reyang @CodeBlanch