-
Notifications
You must be signed in to change notification settings - Fork 774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zipkin Span tags will no longer be populated with Resource Attributes #1663
Merged
cijothomas
merged 7 commits into
open-telemetry:master
from
Austin-Tan:ZipkinRemoveResourceTags
Jan 27, 2021
Merged
Zipkin Span tags will no longer be populated with Resource Attributes #1663
cijothomas
merged 7 commits into
open-telemetry:master
from
Austin-Tan:ZipkinRemoveResourceTags
Jan 27, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddynaka
reviewed
Dec 17, 2020
Austin-Tan
commented
Dec 22, 2020
test/OpenTelemetry.Exporter.Zipkin.Tests/ZipkinExporterTests.cs
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #1663 +/- ##
==========================================
- Coverage 82.17% 82.13% -0.05%
==========================================
Files 250 250
Lines 6767 6763 -4
==========================================
- Hits 5561 5555 -6
- Misses 1206 1208 +2
|
cijothomas
approved these changes
Jan 27, 2021
More changes are needed in light of recent spec changes about default resource. But that can be separate PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1656.
Changes
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes