Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zipkin Span tags will no longer be populated with Resource Attributes #1663

Merged
merged 7 commits into from
Jan 27, 2021
Merged

Zipkin Span tags will no longer be populated with Resource Attributes #1663

merged 7 commits into from
Jan 27, 2021

Conversation

Austin-Tan
Copy link
Member

Fixes #1656.

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #
  • Changes in public API reviewed

@Austin-Tan Austin-Tan requested a review from a team December 17, 2020 01:34
@codecov
Copy link

codecov bot commented Dec 22, 2020

Codecov Report

Merging #1663 (a8a5fb8) into master (842daff) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1663      +/-   ##
==========================================
- Coverage   82.17%   82.13%   -0.05%     
==========================================
  Files         250      250              
  Lines        6767     6763       -4     
==========================================
- Hits         5561     5555       -6     
- Misses       1206     1208       +2     
Impacted Files Coverage Δ
...rc/OpenTelemetry.Exporter.Zipkin/ZipkinExporter.cs 87.50% <100.00%> (-0.55%) ⬇️
...emetry.Api/Internal/OpenTelemetryApiEventSource.cs 76.47% <0.00%> (-5.89%) ⬇️
...metry.Exporter.Zipkin/Implementation/ZipkinSpan.cs 94.50% <0.00%> (-1.10%) ⬇️
...Telemetry/Internal/SelfDiagnosticsEventListener.cs 94.28% <0.00%> (+1.42%) ⬆️

@Austin-Tan Austin-Tan closed this Jan 6, 2021
@Austin-Tan Austin-Tan reopened this Jan 6, 2021
@cijothomas
Copy link
Member

More changes are needed in light of recent spec changes about default resource. But that can be separate PRs.

@cijothomas cijothomas merged commit 9e9987a into open-telemetry:master Jan 27, 2021
@Austin-Tan Austin-Tan deleted the ZipkinRemoveResourceTags branch January 28, 2021 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Resources from being exported in Zipkin
4 participants