Removed dependency from ConsoleExporter #1760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reyang
reviewed
Jan 30, 2021
| @@ -26,12 +25,13 @@ namespace OpenTelemetry.Tests.Trace | |||
| public class ExportProcessorTest | |||
| { | |||
| private const string ActivitySourceName = "ActivityExportProcessorTest"; | |||
| private List<Activity> exportedActivities = new List<Activity>(); | |||
There was a problem hiding this comment.
not blocking this PR, if the intention is to allow multiple test cases to run concurrently, consider using a thread safe version (e.g. concurrent collection)
There was a problem hiding this comment.
I believe xUnit creates a new instance of the class for each of the tests in the class. So these tests don't share the collection. I could move the instantiation to the constructor.
Codecov Report
@@ Coverage Diff @@
## main #1760 +/- ##
==========================================
+ Coverage 83.16% 84.04% +0.88%
==========================================
Files 193 187 -6
Lines 5986 5916 -70
==========================================
- Hits 4978 4972 -6
+ Misses 1008 944 -64 |
cijothomas
reviewed
Jan 30, 2021
cijothomas
reviewed
Jan 30, 2021
cijothomas
approved these changes
Jan 30, 2021
utpilla
deleted the
utpilla/Remove-ConsoleExporter-Dependency-From-Sdk-Tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes