Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid code coverage run on push trigger #1849

Merged
merged 1 commit into from
Feb 25, 2021
Merged

Avoid code coverage run on push trigger #1849

merged 1 commit into from
Feb 25, 2021

Conversation

reyang
Copy link
Member

@reyang reyang commented Feb 24, 2021

I think we're not enforcing code coverage today? It is a bit misleading to see the latest push failed the CI:

image

@reyang reyang requested a review from a team February 24, 2021 22:28
@reyang reyang added the infra Infra work - CI/CD, code coverage, linters label Feb 24, 2021
@cijothomas
Copy link
Member

@eddynaka do you recollect the reason behind adding this? We added to get code coverage comparison with main branch or something?

@eddynaka
Copy link
Contributor

@eddynaka do you recollect the reason behind adding this? We added to get code coverage comparison with main branch or something?

Hi @cijothomas , i think the important part is that we have to run in main and in the branch. Because those would be used to compare between changes. So, the push itself isn't needed.

@codecov
Copy link

codecov bot commented Feb 24, 2021

Codecov Report

Merging #1849 (a61b520) into main (cb066cb) will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1849      +/-   ##
==========================================
- Coverage   83.77%   83.69%   -0.09%     
==========================================
  Files         187      187              
  Lines        5967     5967              
==========================================
- Hits         4999     4994       -5     
- Misses        968      973       +5     
Impacted Files Coverage Δ
...ZPages/Implementation/ZPagesExporterEventSource.cs 56.25% <0.00%> (-6.25%) ⬇️
...emetry.Api/Internal/OpenTelemetryApiEventSource.cs 76.47% <0.00%> (-5.89%) ⬇️
...lemetry/Internal/SelfDiagnosticsConfigRefresher.cs 86.79% <0.00%> (-2.84%) ⬇️
...ter.ZPages/Implementation/ZPagesActivityTracker.cs 100.00% <0.00%> (+2.85%) ⬆️

@cijothomas cijothomas merged commit a1ff609 into main Feb 25, 2021
@cijothomas cijothomas deleted the reyang/ci branch February 25, 2021 00:14
cijothomas added a commit that referenced this pull request Mar 10, 2021
cijothomas added a commit that referenced this pull request Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra Infra work - CI/CD, code coverage, linters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants