-
Notifications
You must be signed in to change notification settings - Fork 772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated AddLegacyActivity method name to AddLegacySource #1860
Updated AddLegacyActivity method name to AddLegacySource #1860
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1860 +/- ##
==========================================
- Coverage 83.77% 83.34% -0.44%
==========================================
Files 187 188 +1
Lines 5967 6130 +163
==========================================
+ Hits 4999 5109 +110
- Misses 968 1021 +53
|
@@ -132,9 +132,9 @@ internal TracerProviderBuilder AddProcessor(BaseProcessor<Activity> processor) | |||
/// <summary> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the code comments should use a plural tense. Here's an alternative:
/// <summary>
/// Adds a listener for <see cref="Activity"/> objects created with the given operation name to the <see cref="TracerProviderBuilder"/>.
/// </summary>
/// <remarks>
/// This is provided to capture legacy <see cref="Activity"/> objects creared without using the <see cref="ActivitySource"/> API.
/// </remarks>
/// <param name="tracerProviderBuilder"><see cref="TracerProviderBuilder"/> instance.</param>
/// <param name="operationName">Operation name of the <see cref="Activity"/> objects to capture.</param>
/// <returns>Returns <see cref="TracerProviderBuilder"/> for chaining.</returns>
public static TracerProviderBuilder AddLegacyActivity(this TracerProviderBuilder tracerProviderBuilder, string operationName)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have updated the code comments.
src/OpenTelemetry/CHANGELOG.md
Outdated
@@ -9,16 +9,20 @@ please check the latest changes | |||
|
|||
## Unreleased | |||
|
|||
* Added `ForceFlush` to `TracerProvider`. ([#1837](https://github.com/open-telemetry/opentelemetry-dotnet/pull/1837)) | |||
* Updated the method name of `AddLegacyActivity` to `AddLegacySource` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need of this. as this was never released.
…acyActivity-To-AddLegacySource
…ttps://github.com/utpilla/opentelemetry-dotnet into utpilla/Update-AddLegacyActivity-To-AddLegacySource
Changes
AddLegacyActivity
toAddLegacySource
CHANGELOG.md
updated for non-trivial changes