[WIP] Automatically get exception message and set to Span.Status #1874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Codecov Report
@@ Coverage Diff @@
## main #1874 +/- ##
==========================================
- Coverage 83.77% 83.36% -0.41%
==========================================
Files 187 188 +1
Lines 5967 6139 +172
==========================================
+ Hits 4999 5118 +119
- Misses 968 1021 +53
|
reyang
commented
Mar 7, 2021
|
|
||
| switch (exceptionRecord.ExceptionCode) | ||
| { | ||
| case EXCEPTION_CODE.EXCEPTION_COMPLUS: |
There was a problem hiding this comment.
There was a problem hiding this comment.
reyang
commented
Mar 7, 2021
| } | ||
|
|
||
| activity.SetTag("exceptionRecord.NumberParameters", exceptionRecord.NumberParameters); | ||
| activity.SetTag("exceptionRecord.ExceptionInformation", exceptionRecord.ExceptionInformation); |
There was a problem hiding this comment.
The actual layout of the ExceptionInformation array is depending on the implementation:
- https://github.com/dotnet/runtime/blob/79ae74f5ca5c8a6fe3a48935e85bd7374959c570/src/coreclr/inc/ex.h#L38
- https://github.com/dotnet/runtime/blob/79ae74f5ca5c8a6fe3a48935e85bd7374959c570/src/coreclr/inc/ex.h#L49
- https://github.com/dotnet/runtime/blob/79ae74f5ca5c8a6fe3a48935e85bd7374959c570/src/coreclr/vm/clrex.cpp#L2156
There was a problem hiding this comment.
ExceptionInformation[4] has different meaning depending on the condition compilation - related to side-by-side.
There was a problem hiding this comment.
!sos.pe might give some clue, worst case is that the logic is duplicated in mscordacwks.dll...
reyang
commented
Mar 7, 2021
| // exceptionRecord.ExceptionInformation[2] == 0 | ||
| // exceptionRecord.ExceptionInformation[3] == 0 | ||
|
|
||
| var pClrModuleBase = exceptionRecord.ExceptionInformation[4]; |
There was a problem hiding this comment.
This points to the base image address of clr.dll or coreclr.dll.
reyang
changed the title
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to the previous PR comment.
To play with the current code, use
docs\trace\exception-handling> dotnet run --framework net5.0.Current thinking:
EXCEPTION_RECORD.ExceptionCode, if code is0xE0434352, proceed to step 2, otherwise exit since it is not a CLRException.EXCEPTION_RECORD, fetch theSystem.Exceptionobject (might need to pin the object on GC?).Reference: