-
Notifications
You must be signed in to change notification settings - Fork 764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor for DataValue #2093
Refactor for DataValue #2093
Conversation
Codecov Report
@@ Coverage Diff @@
## metrics #2093 +/- ##
===========================================
- Coverage 83.00% 82.96% -0.05%
===========================================
Files 209 211 +2
Lines 6698 6694 -4
===========================================
- Hits 5560 5554 -6
- Misses 1138 1140 +2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I just have one question: In the proto and the spec, Attribute
or Label
is used as the name for Key-Value pairs, whereas here, Tag
is used - I might be comparing apples to oranges here, so if I do, please let me know, but would it make sense to keep the naming consistent everywhere as much as possible? Or is there some guidance on when to use what that that I simply missed?
@pirgeo You are correct. We need to rename |
Refactor out
value
portion of IDataPoint to a IDataValue.