-
Notifications
You must be signed in to change notification settings - Fork 772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove upper constraint for Ms.Extensions. dependencies #2179
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2179 +/- ##
=======================================
Coverage 74.66% 74.66%
=======================================
Files 217 217
Lines 6974 6974
=======================================
Hits 5207 5207
Misses 1767 1767 |
We are still working with .NET runtime team to clarify the support policy - |
I think this is Asp.Net Core (on .NET Framework), and not the "pure" Asp.Net. For such projects, the targetframework in the csproj would be net46 or net47 etc, but the nuget packages are M.E.** 2.1.*... |
@shirhatti Please check if this looks good! |
Updated the changes and description accounting for this scenario. Please re-review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Once we get an ack from .NET runtime team that, Msft.Extensions.* packages will always remain backward compatible, we can remove the upper bound restriction on Msft.Extensions package. As of today, we have <6 allowed, blocking .NET 6 preview users.
This also ups the minimum version to be 3.1 (instead of 2.1), as this update will be released along 1.2.0 (Nov 2021), and 2.1* packages are out of support then.The minimum version is kept as 2.1, to support Asp.Net Core 2.1 applications which target the .NET Framework.
Changes
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes