Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple version of Explicit Boundary Histogram. #2207

Closed
wants to merge 8 commits into from

Conversation

victlu
Copy link
Contributor

@victlu victlu commented Jul 29, 2021

Add a simple implementation of an Explicit Boundary Histogram metric aggregator.

@victlu victlu requested review from cijothomas and a team July 29, 2021 01:33
@cijothomas
Copy link
Member

@victlu could you fix the CI failures, when you get a chance, and we are good to merge.

@codecov
Copy link

codecov bot commented Jul 30, 2021

Codecov Report

Merging #2207 (3e13bc0) into main (54d46d8) will increase coverage by 0.54%.
The diff coverage is 82.05%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2207      +/-   ##
==========================================
+ Coverage   80.98%   81.53%   +0.54%     
==========================================
  Files         217      217              
  Lines        6994     7029      +35     
==========================================
+ Hits         5664     5731      +67     
+ Misses       1330     1298      -32     
Impacted Files Coverage Δ
...ics/MetricAggregators/HistogramMetricAggregator.cs 84.61% <82.05%> (+84.61%) ⬆️
...emetry.Api/Internal/OpenTelemetryApiEventSource.cs 82.35% <0.00%> (+2.94%) ⬆️

@cijothomas cijothomas closed this Jul 30, 2021
@cijothomas cijothomas reopened this Jul 30, 2021
@victlu
Copy link
Contributor Author

victlu commented Jul 30, 2021

Technical issues. Created new PR in:
#2216

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants