Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add environment variable detectors to the default ResourceBuilder #2247

Merged
merged 5 commits into from
Aug 13, 2021

Conversation

pellared
Copy link
Member

Per discussion: #2209 (comment)

Changes

Add AddEnvironmentVariableDetector to ResourceBuilder.CreateDefault

@pellared pellared requested a review from a team August 11, 2021 09:51
@pellared pellared changed the title Make env var detector ootb Add environment variable detectors to the default ResourceBuilder Aug 11, 2021
@codecov
Copy link

codecov bot commented Aug 11, 2021

Codecov Report

Merging #2247 (8e35e3d) into main (b663b65) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2247      +/-   ##
==========================================
- Coverage   79.12%   79.10%   -0.03%     
==========================================
  Files         237      237              
  Lines        7484     7484              
==========================================
- Hits         5922     5920       -2     
- Misses       1562     1564       +2     
Impacted Files Coverage Δ
src/OpenTelemetry/Resources/ResourceBuilder.cs 92.85% <100.00%> (ø)
...Zipkin/Implementation/ZipkinExporterEventSource.cs 63.63% <0.00%> (-9.10%) ⬇️
...emetry.Api/Internal/OpenTelemetryApiEventSource.cs 79.41% <0.00%> (-2.95%) ⬇️

Copy link
Contributor

@dszmigielski dszmigielski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pellared pellared requested a review from cijothomas August 12, 2021 06:17
@cijothomas cijothomas merged commit 0959e56 into open-telemetry:main Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants