-
Notifications
You must be signed in to change notification settings - Fork 772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log dropped telemetry item count on shutdown #2331
Log dropped telemetry item count on shutdown #2331
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need a changelog entry 😃
Codecov Report
@@ Coverage Diff @@
## main #2331 +/- ##
==========================================
+ Coverage 79.95% 80.01% +0.05%
==========================================
Files 231 231
Lines 7453 7464 +11
==========================================
+ Hits 5959 5972 +13
+ Misses 1494 1492 -2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have left a comment about making this more useful for end user.
src/OpenTelemetry.Exporter.OpenTelemetryProtocol/OtlpExporterOptions.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test/OpenTelemetry.Exporter.OpenTelemetryProtocol.Tests/OtlpExporterOptionsTests.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Reiley Yang <reyang@microsoft.com>
…opentelemetry-dotnet into inform-of-dropped-items
@mic-max Looks like changelog has conflicts that must be resolved before we can merge. Can you fix them ? |
This feature is important as we want to let users know somehow that we are dropping items.
Changes
this.droppedCount % N == 0
should happen on the line beforeInterlocked.Increment(ref this.droppedCount);
No dropped items:
Dropped items:
Note: I think the extra space at the end is being added by PerfView?
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes