-
Notifications
You must be signed in to change notification settings - Fork 772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add metrics exporter modes #2353
Merged
cijothomas
merged 6 commits into
open-telemetry:main
from
reyang:reyang/metrics-export-mode
Sep 15, 2021
Merged
Add metrics exporter modes #2353
cijothomas
merged 6 commits into
open-telemetry:main
from
reyang:reyang/metrics-export-mode
Sep 15, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2353 +/- ##
==========================================
- Coverage 81.08% 80.62% -0.46%
==========================================
Files 228 229 +1
Lines 7305 7318 +13
==========================================
- Hits 5923 5900 -23
- Misses 1382 1418 +36
|
reyang
force-pushed
the
reyang/metrics-export-mode
branch
from
September 15, 2021 01:17
b629336
to
a115014
Compare
CodeBlanch
reviewed
Sep 15, 2021
CodeBlanch
reviewed
Sep 15, 2021
reyang
commented
Sep 15, 2021
3 tasks
cijothomas
approved these changes
Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced
ExportModes
attribute for metric exporters.With the change, the SDK will throw exception if the user is trying to setup a
PeriodicExportingMetricReader
with an exporter which only supports pull mode.PrometheusExporter will look like:
If someone is doing this:
an
InvalidOperationException("The exporter does not support push mode.")
will be thrown.