Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable C# 10 #2599

Merged
merged 1 commit into from
Nov 12, 2021
Merged

Enable C# 10 #2599

merged 1 commit into from
Nov 12, 2021

Conversation

reyang
Copy link
Member

@reyang reyang commented Nov 12, 2021

This has potential to save 4 spaces on almost every line...

https://docs.microsoft.com/dotnet/csharp/whats-new/csharp-10

@reyang reyang requested a review from a team November 12, 2021 04:14
@reyang reyang added the infra Infra work - CI/CD, code coverage, linters label Nov 12, 2021
@codecov
Copy link

codecov bot commented Nov 12, 2021

Codecov Report

Merging #2599 (ba5cd78) into main (4c22707) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2599   +/-   ##
=======================================
  Coverage   80.30%   80.30%           
=======================================
  Files         256      256           
  Lines        8814     8814           
=======================================
  Hits         7078     7078           
  Misses       1736     1736           

Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cijothomas cijothomas merged commit 4929bfd into open-telemetry:main Nov 12, 2021
@reyang reyang deleted the reyang/csharp-10 branch November 12, 2021 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra Infra work - CI/CD, code coverage, linters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants