-
Notifications
You must be signed in to change notification settings - Fork 774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ZipkinExporter: HttpClientFactory option #2654
ZipkinExporter: HttpClientFactory option #2654
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2654 +/- ##
==========================================
+ Coverage 81.32% 82.25% +0.93%
==========================================
Files 247 247
Lines 8664 8691 +27
==========================================
+ Hits 7046 7149 +103
+ Misses 1618 1542 -76
|
…nch/opentelemetry-dotnet into zipkin-httpclientfactory
* `MaxPayloadSizeInBytes`: Maximum payload size - for .NET versions **other** | ||
than 4.5.2 (default 4096). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't 4.6.1
the lowest version we support now. I guess this comment is from when it was supported, and we no longer need to call it out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes
HttpClientFactory
option we have onJaegerExporterOptions
toZipkinExporterOptions
.IHttpClientFactory
integration whenIDeferredTracerProviderBuilder
is used.TODOs
CHANGELOG.md
updated for non-trivial changes