Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor temporality to align with the spec #2666

Merged
merged 4 commits into from
Nov 23, 2021

Conversation

reyang
Copy link
Member

@reyang reyang commented Nov 23, 2021

Related to open-telemetry/opentelemetry-specification#2154.

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #
  • Changes in public API reviewed

@reyang reyang requested a review from a team November 23, 2021 20:51
Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changelog too.

@codecov
Copy link

codecov bot commented Nov 23, 2021

Codecov Report

Merging #2666 (06cd90f) into main (8d339bb) will decrease coverage by 0.01%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2666      +/-   ##
==========================================
- Coverage   82.29%   82.27%   -0.02%     
==========================================
  Files         249      249              
  Lines        8703     8689      -14     
==========================================
- Hits         7162     7149      -13     
+ Misses       1541     1540       -1     
Impacted Files Coverage Δ
...porter.OpenTelemetryProtocol/OtlpMetricExporter.cs 0.00% <ø> (ø)
...nTelemetryProtocol/OtlpMetricExporterExtensions.cs 0.00% <0.00%> (ø)
src/OpenTelemetry/Metrics/MetricReader.cs 87.87% <85.71%> (+0.04%) ⬆️
...lemetry/Metrics/AggregationTemporalityAttribute.cs 100.00% <100.00%> (ø)
...OpenTelemetry/Metrics/BaseExportingMetricReader.cs 89.09% <100.00%> (-0.20%) ⬇️
src/OpenTelemetry/Metrics/MetricReaderExt.cs 90.32% <100.00%> (-0.11%) ⬇️

@reyang reyang force-pushed the reyang/temporality branch from df2c1bd to 924d7b4 Compare November 23, 2021 21:18
@cijothomas cijothomas merged commit fb161af into open-telemetry:main Nov 23, 2021
@reyang reyang deleted the reyang/temporality branch November 23, 2021 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants