Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated microservice example projects to support c# 10 during docker builds #2677

Merged
merged 5 commits into from
Nov 24, 2021
Merged

Updated microservice example projects to support c# 10 during docker builds #2677

merged 5 commits into from
Nov 24, 2021

Conversation

ktmitton
Copy link
Contributor

Updated the target frameworks for the microservice example projects to net6.0 to support the c# 10 requirement during build through the docker pipeline

Fixes #2676.

Changes

  • Changed the target frameworks of MicroServiceExample/WorkerService and MicroServiceExample/WebApi to net6.0
  • Updated the associated Dockerfiles to use the net6.0 images

…o net6.0 to support the c# 10 requirement during build through the docker pipeline
@ktmitton ktmitton requested a review from a team as a code owner November 24, 2021 02:49
@linux-foundation-easycla
Copy link

CLA Not Signed

1 similar comment
@linux-foundation-easycla
Copy link

CLA Not Signed

@reyang
Copy link
Member

reyang commented Nov 24, 2021

@ktmitton thanks for the contribution, would you clear the CLA?

image

@ktmitton
Copy link
Contributor Author

@ktmitton thanks for the contribution, would you clear the CLA?

image

Trying to, but for some reason it's not taking. I'll have to revisit this tomorrow, sorry.

@codecov
Copy link

codecov bot commented Nov 24, 2021

Codecov Report

Merging #2677 (cbab746) into main (9e83587) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2677      +/-   ##
==========================================
- Coverage   82.89%   82.87%   -0.03%     
==========================================
  Files         249      249              
  Lines        8705     8705              
==========================================
- Hits         7216     7214       -2     
- Misses       1489     1491       +2     
Impacted Files Coverage Δ
...ter.ZPages/Implementation/ZPagesActivityTracker.cs 97.14% <0.00%> (-2.86%) ⬇️
...nTelemetry/Internal/OpenTelemetrySdkEventSource.cs 70.47% <0.00%> (-0.96%) ⬇️

@ktmitton
Copy link
Contributor Author

@ktmitton thanks for the contribution, would you clear the CLA?

image

Ok, looks like it's good now. First time I've had to use this, sorry for the inconvenience!

@WillsonHG
Copy link

/easycla

@cijothomas cijothomas merged commit d7ea809 into open-telemetry:main Nov 24, 2021
@ktmitton ktmitton deleted the microserviceTargetFrameworkUpdate branch November 25, 2021 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Microservice example fails to build
4 participants