-
Notifications
You must be signed in to change notification settings - Fork 772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MetricType modification to allow future additions to histogram #2693
Merged
cijothomas
merged 11 commits into
open-telemetry:main
from
cijothomas:cijothomas/metrictypeenum1
Nov 29, 2021
Merged
MetricType modification to allow future additions to histogram #2693
cijothomas
merged 11 commits into
open-telemetry:main
from
cijothomas:cijothomas/metrictypeenum1
Nov 29, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2693 +/- ##
=======================================
Coverage ? 82.97%
=======================================
Files ? 249
Lines ? 8703
Branches ? 0
=======================================
Hits ? 7221
Misses ? 1482
Partials ? 0
|
reyang
reviewed
Nov 26, 2021
reyang
reviewed
Nov 26, 2021
src/OpenTelemetry.Exporter.Prometheus/Implementation/PrometheusSerializerExt.cs
Outdated
Show resolved
Hide resolved
reyang
reviewed
Nov 28, 2021
src/OpenTelemetry.Exporter.Prometheus/Implementation/PrometheusSerializerExt.cs
Outdated
Show resolved
Hide resolved
reyang
reviewed
Nov 28, 2021
…sSerializerExt.cs Co-authored-by: Reiley Yang <reyang@microsoft.com>
reyang
approved these changes
Nov 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MetricType modification to allow future additions to Histogram.