Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MetricType modification to allow future additions to histogram #2693

Merged
merged 11 commits into from
Nov 29, 2021

Conversation

cijothomas
Copy link
Member

MetricType modification to allow future additions to Histogram.

@cijothomas cijothomas requested a review from a team November 26, 2021 21:03
@codecov
Copy link

codecov bot commented Nov 26, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@284885b). Click here to learn what that means.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2693   +/-   ##
=======================================
  Coverage        ?   82.97%           
=======================================
  Files           ?      249           
  Lines           ?     8703           
  Branches        ?        0           
=======================================
  Hits            ?     7221           
  Misses          ?     1482           
  Partials        ?        0           
Impacted Files Coverage Δ
...ometheus/Implementation/PrometheusSerializerExt.cs 100.00% <100.00%> (ø)
src/OpenTelemetry/Metrics/MetricTypeExtensions.cs 40.00% <100.00%> (ø)

@cijothomas cijothomas merged commit f153cb1 into open-telemetry:main Nov 29, 2021
@cijothomas cijothomas deleted the cijothomas/metrictypeenum1 branch November 29, 2021 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants