Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make MetricPoint access from MetricPointAccessor readonly #2736

Conversation

utpilla
Copy link
Contributor

@utpilla utpilla commented Dec 9, 2021

Fixes the issue described in #2731

Changes

  • Make MetricPoint access from MetricPointAccessor readonly

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #
  • Changes in public API reviewed

@utpilla utpilla requested a review from a team December 9, 2021 00:37
@codecov
Copy link

codecov bot commented Dec 9, 2021

Codecov Report

Merging #2736 (20a1126) into main (83fa9fd) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2736      +/-   ##
==========================================
+ Coverage   83.73%   83.76%   +0.02%     
==========================================
  Files         250      250              
  Lines        8824     8824              
==========================================
+ Hits         7389     7391       +2     
+ Misses       1435     1433       -2     
Impacted Files Coverage Δ
src/OpenTelemetry/Metrics/MetricPointsAccessor.cs 100.00% <ø> (ø)
...tryProtocol/Implementation/MetricItemExtensions.cs 93.52% <100.00%> (ø)
...ometheus/Implementation/PrometheusSerializerExt.cs 100.00% <100.00%> (ø)
...emetry.Api/Internal/OpenTelemetryApiEventSource.cs 79.41% <0.00%> (-2.95%) ⬇️
src/OpenTelemetry/BatchExportProcessor.cs 89.13% <0.00%> (+3.26%) ⬆️

@cijothomas cijothomas merged commit 33f3596 into open-telemetry:main Dec 14, 2021
@cijothomas
Copy link
Member

Missing changelog. Will do as a separate follow up PR.

@utpilla utpilla deleted the utpilla/Make-MetricPoint-Access-ReadOnly branch November 3, 2023 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants