Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Span creation takes Func<IEnumerable<Links>> to optimize on NoOp #282

Merged
merged 23 commits into from
Oct 22, 2019
Merged

Span creation takes Func<IEnumerable<Links>> to optimize on NoOp #282

merged 23 commits into from
Oct 22, 2019

Conversation

bruno-garcia
Copy link
Member

@bruno-garcia bruno-garcia commented Oct 15, 2019 •
edited
Loading

@bruno-garcia bruno-garcia changed the title wip Span creation takes Func<IEnumerable<Links>> to optimize on NoOp Oct 15, 2019
@bruno-garcia bruno-garcia mentioned this pull request Oct 15, 2019
Closed
lmolkova
lmolkova reviewed Oct 15, 2019
View reviewed changes
Copy link

@lmolkova lmolkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should avoid allocations when creating lambda functions for links. If it's not possible or too hard we have to keep overload with IEnumerable Link

@bruno-garcia
Copy link
Member Author

@lmolkova I've started with the overload: 613b11f
So far I've duplicated a ton of code so I guess I need to take a better look if there's a better way.
Let me know what you think

@bruno-garcia bruno-garcia marked this pull request as ready for review October 21, 2019 02:26
@bruno-garcia bruno-garcia reopened this Oct 21, 2019
@bruno-garcia
Copy link
Member Author

@lmolkova Hopefully a bit closer to completion so removed the draft status.
I'll try respond to feedback during the week so we don't need yet another weekend to get this done.

@bruno-garcia bruno-garcia requested a review from lmolkova October 21, 2019 02:35
@bruno-garcia
Copy link
Member Author

bruno-garcia commented Oct 22, 2019 •
edited
Loading

@lmolkova Should be close to merge now, let me know of any blockers.
Thanks for your review once again!

@bruno-garcia
Copy link
Member Author

got caught*

@bruno-garcia
ref: including max value
9b1e1c6 
Co-Authored-By: Liudmila Molkova <lmolkova@microsoft.com>
@lmolkova lmolkova merged commit 0610a5b into open-telemetry:master Oct 22, 2019
@SergeyKanzhelev SergeyKanzhelev mentioned this pull request Oct 28, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmolkova lmolkova lmolkova approved these changes

@austinlparker austinlparker Awaiting requested review from austinlparker

@discostu105 discostu105 Awaiting requested review from discostu105

@SergeyKanzhelev SergeyKanzhelev Awaiting requested review from SergeyKanzhelev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bruno-garcia @lmolkova