-
Notifications
You must be signed in to change notification settings - Fork 772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OTLPExporter unhandled exceptions #2915
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM assume changelog is included.
Codecov Report
@@ Coverage Diff @@
## main #2915 +/- ##
==========================================
+ Coverage 83.97% 83.98% +0.01%
==========================================
Files 254 254
Lines 8918 8918
==========================================
+ Hits 7489 7490 +1
+ Misses 1429 1428 -1
|
No worries. The current code coverage result is not stable (each run will have slightly different results) and is not considered as a blocker for the PR. Given this is not the first time folks asked about this, I'm thinking - maybe for short term we should change the codecov CI so it only shows the coverage percentage but always return Success? In this way it still serves the purpose of giving us a rough estimation of the test coverage, but won't introduce confusion to the contributors? @open-telemetry/dotnet-approvers @open-telemetry/dotnet-maintainers what do you think? |
#2872
Changes