Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OTLPExporter unhandled exceptions #2915

Merged
merged 5 commits into from
Feb 22, 2022
Merged

Conversation

glucaci
Copy link
Contributor

@glucaci glucaci commented Feb 18, 2022

#2872

Changes

  • Include batch transformation into try/catch scope

@glucaci glucaci requested a review from a team February 18, 2022 07:10
Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assume changelog is included.

@codecov
Copy link

codecov bot commented Feb 18, 2022

Codecov Report

Merging #2915 (f714d0b) into main (4b3ee96) will increase coverage by 0.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2915      +/-   ##
==========================================
+ Coverage   83.97%   83.98%   +0.01%     
==========================================
  Files         254      254              
  Lines        8918     8918              
==========================================
+ Hits         7489     7490       +1     
+ Misses       1429     1428       -1     
Impacted Files Coverage Δ
....Exporter.OpenTelemetryProtocol/OtlpLogExporter.cs 0.00% <0.00%> (ø)
...porter.OpenTelemetryProtocol/OtlpMetricExporter.cs 72.72% <100.00%> (ø)
...xporter.OpenTelemetryProtocol/OtlpTraceExporter.cs 59.09% <100.00%> (ø)
...lemetry/Internal/SelfDiagnosticsConfigRefresher.cs 89.42% <0.00%> (-2.89%) ⬇️
...nTelemetry/Internal/OpenTelemetrySdkEventSource.cs 75.00% <0.00%> (+1.85%) ⬆️
...emetry.Api/Internal/OpenTelemetryApiEventSource.cs 82.35% <0.00%> (+5.88%) ⬆️

@glucaci
Copy link
Contributor Author

glucaci commented Feb 19, 2022

I didn't touch this part 🙄
image

@reyang
Copy link
Member

reyang commented Feb 19, 2022

I didn't touch this part 🙄 image

No worries. The current code coverage result is not stable (each run will have slightly different results) and is not considered as a blocker for the PR.
I guess the codecov issue could either be related to the tool itself (e.g. some bug, although I think it's less likely to be the case) or the how the test cases were designed (e.g. some test cases require RPC interactions or some other operations that are sensitive to timing/race).

Given this is not the first time folks asked about this, I'm thinking - maybe for short term we should change the codecov CI so it only shows the coverage percentage but always return Success? In this way it still serves the purpose of giving us a rough estimation of the test coverage, but won't introduce confusion to the contributors? @open-telemetry/dotnet-approvers @open-telemetry/dotnet-maintainers what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants