Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publicize required methods to allow for custom implementations of resource detectors. #2949
Publicize required methods to allow for custom implementations of resource detectors. #2949
Changes from 10 commits
8857133
fd4b86e
065aadb
fade88d
bd1e1e6
6a6e74d
bac96b9
3806ef7
fd4f888
d3a822a
172d6cd
53ce18b
4357492
4adc9b2
99082c3
046168b
d61fb20
ab6ce9a
681cc0e
2edd942
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not directly related to this PR, this line seems complex, maybe it could be simplified to
ResourceBuilder.AddDetector(new MyResourceDetector())
? (by tweaking the static method)