Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Support Status and StatusDescription from Activity class #2996

Closed
wants to merge 11 commits into from

Conversation

Yun-Ting
Copy link
Contributor

@Yun-Ting Yun-Ting commented Mar 9, 2022

Partially Fixes #.
#2569

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #
  • Changes in public API reviewed

@codecov
Copy link

codecov bot commented Mar 9, 2022

Codecov Report

Merging #2996 (1ab2baa) into main (98cb289) will increase coverage by 0.17%.
The diff coverage is 100.00%.

❗ Current head 1ab2baa differs from pull request most recent head 2539d45. Consider uploading reports for the commit 2539d45 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2996      +/-   ##
==========================================
+ Coverage   83.91%   84.08%   +0.17%     
==========================================
  Files         250      255       +5     
  Lines        8958     9080     +122     
==========================================
+ Hits         7517     7635     +118     
- Misses       1441     1445       +4     
Impacted Files Coverage Δ
src/OpenTelemetry.Api/Internal/StatusHelper.cs 100.00% <100.00%> (ø)
...plementation/ZipkinActivityConversionExtensions.cs 98.98% <100.00%> (+0.06%) ⬆️
...ZPages/Implementation/ZPagesExporterEventSource.cs 56.25% <0.00%> (-6.25%) ⬇️
...emetry.Api/Internal/OpenTelemetryApiEventSource.cs 76.47% <0.00%> (-5.89%) ⬇️
...rumentation.AspNet/AspNetInstrumentationOptions.cs 100.00% <0.00%> (ø)
...umentation.AspNet/Implementation/HttpInListener.cs 88.31% <0.00%> (ø)
...entation.AspNet/TracerProviderBuilderExtensions.cs 100.00% <0.00%> (ø)
...Implementation/AspNetInstrumentationEventSource.cs 76.92% <0.00%> (ø)
...ry.Instrumentation.AspNet/AspNetInstrumentation.cs 100.00% <0.00%> (ø)
....AspNet.TelemetryHttpModule/TelemetryHttpModule.cs 5.26% <0.00%> (+5.26%) ⬆️
... and 1 more

@Yun-Ting Yun-Ting closed this Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants